Manually restore omni versions and prevent future issues #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea.fix-omni-state-of-the-world
branch
from
76808f0 to
05079ca
Compare
ericanderson
commented
Jul 29, 2024
| - Updated dependencies [651c1b8] | ||
| - @osdk/[email protected] | ||
| - @osdk/[email protected] | ||
|
|
There was a problem hiding this comment.
Removing changelogs that don't matter
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@osdk/foundry.admin", | |||
| "version": "3.0.0-beta.1", | |||
There was a problem hiding this comment.
Restoring version back to 2.0.0 so we don't ship this as 3.0.0 when we version next
| @@ -224,11 +224,6 @@ const BASE_PACKAGE_JSON = { | |||
| "typecheck": "tsc-absolute", | |||
| }, | |||
| "dependencies": {}, | |||
| "peerDependencies": { | |||
There was a problem hiding this comment.
Don't generate with peer deps for new packages of the platform sdk
ssanjay1
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omni's got hit by the peerDependencies paradox (for lack of a better name). We already oops over to 2.x for them and almost went to 3.x so this gets us back to a stable state and they won't major rev with client updates any more.